fix: trends modal should show the facet in the title by graphieros · Pull Request #1508 · npmx-dev/npmx.dev

graphieros · 2026-02-14T15:08:22Z

use the expected modal-title prop instead of title (typical false positive)
use proper translation for versions chart modal title

vercel · 2026-02-14T15:08:26Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
npmx.dev	Ready	Preview, Comment	Feb 14, 2026 5:43pm

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
docs.npmx.dev	Ignored	Preview	Feb 14, 2026 5:43pm
npmx-lunaria	Ignored		Feb 14, 2026 5:43pm

coderabbitai · 2026-02-14T15:10:11Z

📝 Walkthrough

Walkthrough

The PackageChartModal prop used in package components was renamed from title to modal-title. Weekly downloads UI bindings were updated to use the package.trends.title key instead of package.downloads.*. The i18n schema and many locale files removed downloads.modal_title and downloads.analyze, and numerous locale files added placeholder a11y and team keys.

Possibly related PRs

refactor: generalize i18n keys for download trend charts #1183: Modifies the same translation keys and updates WeeklyDownloadStats.vue to switch downloads-related keys to trends-related keys.
feat(ui): generalize downloads chart and add social likes option #1310: Implements a ChartModal/PackageChartModal prop rename and updates component usages to modal-title/modalTitle.
fix: dialog title switch with select #1497: Changes how PackageChartModal title is provided in WeeklyDownloadStats.vue, touching the same component-prop usage and computed modalTitle.

Suggested reviewers

ghostdevv
serhalp

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description check	✅ Passed	The pull request description clearly relates to the changeset, describing specific changes to prop names and translation keys across component and locale files.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into `main`

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-02-14T15:10:47Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

github-actions · 2026-02-14T15:14:35Z

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File	Note
lunaria/files/ar-EG.json	Localization changed, will be marked as complete. 🔄️
lunaria/files/az-AZ.json	Localization changed, will be marked as complete. 🔄️
lunaria/files/bg-BG.json	Localization changed, will be marked as complete. 🔄️
lunaria/files/bn-IN.json	Localization changed, will be marked as complete. 🔄️
lunaria/files/cs-CZ.json	Localization changed, will be marked as complete. 🔄️
lunaria/files/de-DE.json	Localization changed, will be marked as complete. 🔄️
lunaria/files/en-GB.json	Localization changed, will be marked as complete. 🔄️
lunaria/files/en-US.json	Source changed, localizations will be marked as outdated.
lunaria/files/es-419.json	Localization changed, will be marked as complete. 🔄️
lunaria/files/es-ES.json	Localization changed, will be marked as complete. 🔄️
lunaria/files/fr-FR.json	Localization changed, will be marked as complete. 🔄️
lunaria/files/hi-IN.json	Localization changed, will be marked as complete. 🔄️
lunaria/files/hu-HU.json	Localization changed, will be marked as complete. 🔄️
lunaria/files/id-ID.json	Localization changed, will be marked as complete. 🔄️
lunaria/files/it-IT.json	Localization changed, will be marked as complete. 🔄️
lunaria/files/ja-JP.json	Localization changed, will be marked as complete. 🔄️
lunaria/files/nb-NO.json	Localization changed, will be marked as complete. 🔄️
lunaria/files/ne-NP.json	Localization changed, will be marked as complete. 🔄️
lunaria/files/pl-PL.json	Localization changed, will be marked as complete. 🔄️
lunaria/files/pt-BR.json	Localization changed, will be marked as complete. 🔄️
lunaria/files/ru-RU.json	Localization changed, will be marked as complete. 🔄️
lunaria/files/te-IN.json	Localization changed, will be marked as complete. 🔄️
lunaria/files/uk-UA.json	Localization changed, will be marked as complete. 🔄️
lunaria/files/zh-CN.json	Localization changed, will be marked as complete. 🔄️
lunaria/files/zh-TW.json	Localization changed, will be marked as complete. 🔄️

Warnings reference

Icon	Description
🔄️	The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

coderabbitai

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

lunaria/files/nb-NO.json (1)

965-978: ⚠️ Potential issue | 🟠 Major

Complete Norwegian translation for privacy_policy missing.

The nb-NO.json file contains empty objects for all privacy_policy keys. Translation lookups for privacy_policy.cookies.what_are.title, privacy_policy.analytics.p1, and similar leaf keys will fail, causing untranslated content in the UI. Either populate nb-NO.json with Norwegian translations to match the en-US.json structure or remove the empty privacy_policy section to allow fallbacks to the default locale.

🧹 Nitpick comments (1)

lunaria/files/pl-PL.json (1)

820-827: Consider localising role labels if user-facing.

Lines 823-825: “steward” and “maintainer” remain English; if these are shown to Polish users, translate or align with a glossary for consistency.

lunaria/files/pl-PL.json

ghostdevv · 2026-02-14T15:33:55Z

oh! I just merged #1497 😅 - could you rebase to make any of the changes that it I've missed?

ghostdevv

Merge when ready! @graphieros

fix: use correct title prop

3a69fc1

Merge branch 'main' into main

da2d9ed

vercel bot deployed to Preview – docs.npmx.dev February 14, 2026 15:10 View deployment

vercel bot deployed to Preview – npmx.dev February 14, 2026 15:10 View deployment

chore: remove unused translation

6719a9c

autofix-ci bot and others added 4 commits February 14, 2026 15:14

[autofix.ci] apply automated fixes

e08111e

chore: use proper button title & remove unused translation

b8344b9

Merge branch 'main' of https://github.com/graphieros/npmx.dev

0f8d3e0

[autofix.ci] apply automated fixes

cf9e5e1

vercel bot deployed to Preview – npmx.dev February 14, 2026 15:19 View deployment

graphieros enabled auto-merge February 14, 2026 15:21

coderabbitai bot reviewed Feb 14, 2026

View reviewed changes

lunaria/files/pl-PL.json Show resolved Hide resolved

Merge branch 'main' into main

2ecec7d

vercel bot deployed to Preview – npmx.dev February 14, 2026 15:43 View deployment

fix: use modalTitle variable

ff73bd6

graphieros requested a review from ghostdevv February 14, 2026 15:47

vercel bot deployed to Preview – npmx.dev February 14, 2026 15:48 View deployment

Merge branch 'main' into main

59e6ad3

vercel bot deployed to Preview – npmx.dev February 14, 2026 17:43 View deployment

ghostdevv changed the title ~~fix: use correct title prop~~ fix: trends modal should show the facet in the title Feb 14, 2026

ghostdevv approved these changes Feb 14, 2026

View reviewed changes

graphieros added this pull request to the merge queue Feb 14, 2026

Merged via the queue into npmx-dev:main with commit 7d69561 Feb 14, 2026
17 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: trends modal should show the facet in the title#1508

fix: trends modal should show the facet in the title#1508
graphieros merged 10 commits intonpmx-dev:mainfrom
graphieros:main

graphieros commented Feb 14, 2026 •

edited

Loading

Uh oh!

vercel bot commented Feb 14, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Feb 14, 2026 •

edited

Loading

Walkthrough

Possibly related PRs

Suggested reviewers

Uh oh!

codecov bot commented Feb 14, 2026

Uh oh!

github-actions bot commented Feb 14, 2026 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

ghostdevv commented Feb 14, 2026

Uh oh!

ghostdevv left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

graphieros commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested reviewers

Uh oh!

codecov bot commented Feb 14, 2026

Codecov Report

Uh oh!

github-actions bot commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Lunaria Status Overview

Tracked Files

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ghostdevv commented Feb 14, 2026

Uh oh!

ghostdevv left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

graphieros commented Feb 14, 2026 •

edited

Loading

vercel bot commented Feb 14, 2026 •

edited

Loading

coderabbitai bot commented Feb 14, 2026 •

edited

Loading

github-actions bot commented Feb 14, 2026 •

edited

Loading